Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r/python/c++] Depend on core 2.14, tiledb-r 0.18, tiledb-py 0.20 #770

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

johnkerl
Copy link
Member

Issue and/or context:

#752

Changes:

Only package-version dependency updates.

Notes for Reviewer:

This PR does not implement UTF-8 mods for #415, although it does unblock work in that direction.

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Base: 78.69% // Head: 69.93% // Decreases project coverage by -8.77% ⚠️

Coverage data is based on head (69cdc2c) compared to base (190f216).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   78.69%   69.93%   -8.77%     
==========================================
  Files          30       70      +40     
  Lines        2009     3585    +1576     
==========================================
+ Hits         1581     2507     +926     
- Misses        428     1078     +650     
Flag Coverage Δ
python 78.49% <ø> (-0.20%) ⬇️
r 59.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/python/src/tiledbsoma/collection.py 84.32% <0.00%> (-1.63%) ⬇️
apis/python/src/tiledbsoma/sparse_nd_array.py 94.06% <0.00%> (-0.85%) ⬇️
src/rutilities.cpp 33.33% <0.00%> (ø)
inst/tiledb/include/tiledb/schema_base.h 100.00% <0.00%> (ø)
R/TileDBURI.R 87.87% <0.00%> (ø)
src/rutilities.h 62.50% <0.00%> (ø)
inst/tiledb/include/tiledb/domain.h 100.00% <0.00%> (ø)
inst/tiledb/include/tiledb/deleter.h 100.00% <0.00%> (ø)
inst/tiledb/include/tiledb/core_interface.h 100.00% <0.00%> (ø)
R/TileDBArray.R 87.35% <0.00%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnkerl johnkerl merged commit 8cc1744 into main Jan 20, 2023
@johnkerl johnkerl deleted the kerl/tiledb-core-2.14.0 branch January 20, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants