Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r/python/c++] Depend on core 2.14, tiledb-r 0.18, tiledb-py 0.20 #766

Closed
wants to merge 1 commit into from

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jan 19, 2023

Issue and/or context:

#752

Changes:

Only package-version dependency updates.

Notes for Reviewer:

This PR does not implement UTF-8 mods for #415, although it does unblock work in that direction.

@johnkerl johnkerl force-pushed the kerl/tiledb-core-2.14 branch from ef81e5f to 620d5b6 Compare January 19, 2023 22:15
@johnkerl johnkerl marked this pull request as draft January 19, 2023 22:16
@johnkerl johnkerl changed the base branch from main to kerl/somacore-0.0.0a5 January 19, 2023 22:16
Base automatically changed from kerl/somacore-0.0.0a5 to main January 19, 2023 22:23
@codecov-commenter
Copy link

Codecov Report

Base: 77.86% // Head: 59.01% // Decreases project coverage by -18.86% ⚠️

Coverage data is based on head (4e9ec66) compared to base (04e47f3).
Patch has no changes to coverable lines.

❗ Current head 4e9ec66 differs from pull request most recent head 620d5b6. Consider uploading reports for the commit 620d5b6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #766       +/-   ##
===========================================
- Coverage   77.86%   59.01%   -18.86%     
===========================================
  Files          30       40       +10     
  Lines        2006     1576      -430     
===========================================
- Hits         1562      930      -632     
- Misses        444      646      +202     
Flag Coverage Δ
python ?
r 59.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/python/src/tiledbsoma/util_ann.py
apis/python/src/tiledbsoma/dense_nd_array.py
apis/python/src/tiledbsoma/constants.py
apis/python/src/tiledbsoma/util_scipy.py
apis/python/src/tiledbsoma/factory.py
...on/src/tiledbsoma/options/tiledb_create_options.py
apis/python/src/tiledbsoma/experiment_query.py
apis/python/src/tiledbsoma/tiledb_object.py
apis/python/src/tiledbsoma/util.py
apis/python/src/tiledbsoma/util_iter.py
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnkerl johnkerl force-pushed the kerl/tiledb-core-2.14 branch from 620d5b6 to a317e95 Compare January 19, 2023 22:57
@johnkerl johnkerl marked this pull request as ready for review January 20, 2023 03:50
@johnkerl johnkerl requested a review from bkmartinjr January 20, 2023 03:50
@johnkerl
Copy link
Member Author

Replacing with #770

There were some CI jobs I cancelled earlier while https://pypi.org/project/tiledb wasn't ready; now, even with 'Re-run all jobs' they seem to not be all getting to run. #770 is a clean-slate attempt.

@johnkerl johnkerl closed this Jan 20, 2023
@johnkerl johnkerl deleted the kerl/tiledb-core-2.14 branch January 20, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants