-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Add GHA workflow for minimal CI jobs #750
Conversation
This will run only for pull requests
Codecov ReportBase: 78.76% // Head: 79.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
==========================================
+ Coverage 78.76% 79.35% +0.58%
==========================================
Files 30 30
Lines 1978 1981 +3
==========================================
+ Hits 1558 1572 +14
+ Misses 420 409 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
already run my pre-commit; erroneously left in after merging from main
name: TileDB-SOMA Python CI (Minimal) | ||
|
||
on: | ||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now differs from r-ci.yml, which is not ideal. And the GHA console shows push- and pull_request-triggered workflow runs somewhat differently. I'm going to test once more with pull_request...
@johnkerl @thetorpedodog I'd say this is ready, if we want to move forward with it. I merged in the caching improvements that Paul made earlier today. I never quite figured out why only Not going to spend more time on this, so we can take it or leave it as is. 😄 (I believe the R build failure is known and may be resolved with another merge from main.) |
Yes @atolopko-czi re known-broken R CI pending #766 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atolopko-czi thank you thank you thank you 🙏
I know this was a long slog, and a puzzler, with lots of revs trying to untangle various complexities
But I really do apprecate it -- the more people are actively contributing to SOMA right now, the more we're using CI -- and your work here will help us _all_move faster. :D
See also #693 |
Issue and/or context:
#723
Changes:
python-ci-minimal.yml
GHA workflow for minimal CI jobs, invoked by pushes to feature branchespython-ci.yml
topython-ci-full.yml
, to differentiate from the "minimal" workflow; invoked by pushes to main and for releasespython-ci-single.yml
, which is a reusable workflow called by the "minimal" and "full" workflows.Notes for Reviewer:
Successful workflow runs:
As these requires some temporary hacks to trigger, our final test of the "full" workflow can only be run upon merging this PR to main. 🤞