[r] Simple R UTF-8 test #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you care there are more characters here: (I actually copied those from a real-life application of mine but that is a whole different story ....) |
|
@eddelbuettel done! ✨ |
johnkerl
force-pushed
the
kerl/r-utf8-test
branch
from
dbf7626 to
1c23e27
Compare
eddelbuettel
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#737
Changes:
Simple write-and-read-back tests for UTF-8 strings in
SOMADataFrame.Notes for Reviewer:
There's more we can check, of course. While doing a quick health check with core 2.14 (#770) I typed this up, and it works, and I figured, why not put up an initial PR -- ?