Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/docs] Replace experiment directories with .tgz files in source control #3295

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 5, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

As I noted on #3294 it's awkward and unnecessary to have full experiment directories in source control.

Here I commit the .tgz files to source control, and make the necessary adjustments to our tutorial notebooks.

Notes for Reviewer:

@johnkerl johnkerl changed the title Kerl/notebook data refresh [python/docs] Replace experiment directories with .tgz files in source control Nov 5, 2024
@johnkerl johnkerl force-pushed the kerl/notebook-data-refresh branch from af2778f to 2d41d9a Compare November 5, 2024 22:22
@johnkerl johnkerl force-pushed the kerl/notebook-data-refresh branch from 2d41d9a to 613b050 Compare November 5, 2024 22:23
@johnkerl johnkerl force-pushed the kerl/notebook-data-refresh branch from 53f0c82 to 648ac14 Compare November 5, 2024 22:46
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (762abda) to head (648ac14).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3295      +/-   ##
==========================================
+ Coverage   85.29%   85.40%   +0.10%     
==========================================
  Files          52       52              
  Lines        5517     5517              
==========================================
+ Hits         4706     4712       +6     
+ Misses        811      805       -6     
Flag Coverage Δ
python 85.40% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.40% <ø> (+0.10%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 0dea435 into main Nov 5, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/notebook-data-refresh branch November 5, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants