Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Tutorial notebook for the new-shape feature #3294

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 5, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

@johnkerl johnkerl requested a review from aaronwolen November 5, 2024 22:01
@johnkerl johnkerl marked this pull request as draft November 5, 2024 22:07
@johnkerl
Copy link
Member Author

johnkerl commented Nov 5, 2024

Converting to draft while I do some underwork as I noted above when I said

... update: gurg, those are a lot of files. I definitely think I want to split out a separate PR, wherein I make the data dirs .tgz files which our notebooks extract for use.

@johnkerl johnkerl force-pushed the kerl/notebook-new-shape-refresh branch 4 times, most recently from bd5ab54 to 20d4831 Compare November 5, 2024 23:12
@johnkerl johnkerl force-pushed the kerl/new-shape-notebook-and-vignette branch 2 times, most recently from b7078be to 50210b9 Compare November 5, 2024 23:25
@johnkerl johnkerl force-pushed the kerl/notebook-new-shape-refresh branch from 20d4831 to 23953ae Compare November 6, 2024 15:52
Base automatically changed from kerl/notebook-new-shape-refresh to main November 6, 2024 16:39
@johnkerl johnkerl force-pushed the kerl/new-shape-notebook-and-vignette branch from 50210b9 to ceba815 Compare November 6, 2024 16:39
@johnkerl johnkerl force-pushed the kerl/new-shape-notebook-and-vignette branch from ceba815 to 017ea32 Compare November 6, 2024 16:39
@johnkerl johnkerl changed the title [python/r] Tutorial notebook / vignette for the new-shape feature [python] Tutorial notebook for the new-shape feature Nov 6, 2024
@johnkerl johnkerl marked this pull request as ready for review November 6, 2024 16:40
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (33b104c) to head (017ea32).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3294      +/-   ##
==========================================
+ Coverage   85.29%   85.40%   +0.10%     
==========================================
  Files          52       52              
  Lines        5517     5517              
==========================================
+ Hits         4706     4712       +6     
+ Misses        811      805       -6     
Flag Coverage Δ
python 85.40% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.40% <ø> (+0.10%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have some minor suggestions. Thank you for the link to the notebook; it was very useful.

apis/python/notebooks/tutorial_soma_shape.ipynb Outdated Show resolved Hide resolved
apis/python/notebooks/tutorial_soma_shape.ipynb Outdated Show resolved Hide resolved
apis/python/notebooks/tutorial_soma_shape.ipynb Outdated Show resolved Hide resolved
apis/python/notebooks/tutorial_soma_shape.ipynb Outdated Show resolved Hide resolved
@johnkerl
Copy link
Member Author

johnkerl commented Nov 7, 2024

Merging this round of changes ... @aaronwolen let me know if you have any post-merge feedback and I'm happy to take a follow-on.

Also I'll send the corresponding Academy PRs your way 🙏

@johnkerl johnkerl merged commit 7bb962e into main Nov 7, 2024
@johnkerl johnkerl deleted the kerl/new-shape-notebook-and-vignette branch November 7, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants