-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Tutorial notebook for the new-shape feature #3294
Conversation
8d2c7e4
to
89a5238
Compare
Converting to draft while I do some underwork as I noted above when I said
|
bd5ab54
to
20d4831
Compare
b7078be
to
50210b9
Compare
20d4831
to
23953ae
Compare
50210b9
to
ceba815
Compare
ceba815
to
017ea32
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3294 +/- ##
==========================================
+ Coverage 85.29% 85.40% +0.10%
==========================================
Files 52 52
Lines 5517 5517
==========================================
+ Hits 4706 4712 +6
+ Misses 811 805 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have some minor suggestions. Thank you for the link to the notebook; it was very useful.
Co-authored-by: nguyenv <[email protected]>
Co-authored-by: nguyenv <[email protected]>
Co-authored-by: nguyenv <[email protected]>
Co-authored-by: nguyenv <[email protected]>
Merging this round of changes ... @aaronwolen let me know if you have any post-merge feedback and I'm happy to take a follow-on. Also I'll send the corresponding Academy PRs your way 🙏 |
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Notebook material for Python. (R material will be a separate PR.)
Notes for Reviewer:
The Python material is ready for review.
Handy link for reviewers:
I'm working on the R material.