Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Re-run, and update, example notebooks with new shape feature #3290

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 4, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Re-execute our notebooks with the new-shape feature. Change the wording in many places to remove needless complexities from the pre-shape era.

This PR affects existing notebooks. There is a separate PR with a new notebook dedicated to the new shape feature: #3294.

Notes for Reviewer:

This PR was run on a system with core dev (2.27-to-be) installed on it.

Handy review link with rendered notebooks:
https://github.com/single-cell-data/TileDB-SOMA/tree/kerl/notebook-new-shape-refresh/apis/python/notebooks

@johnkerl johnkerl changed the base branch from main to kerl/dataframe-shape-temp November 4, 2024 00:13
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (0dea435) to head (23953ae).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3290      +/-   ##
==========================================
+ Coverage   85.29%   85.40%   +0.10%     
==========================================
  Files          52       52              
  Lines        5517     5517              
==========================================
+ Hits         4706     4712       +6     
+ Misses        811      805       -6     
Flag Coverage Δ
python 85.40% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.40% <ø> (+0.10%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl force-pushed the kerl/notebook-new-shape-refresh branch from 58b711c to 01473ca Compare November 4, 2024 00:41
@johnkerl johnkerl changed the title [python] Re-run example notebooks with new shape feature [python] Re-run, and update, example notebooks with new shape feature Nov 4, 2024
@johnkerl johnkerl force-pushed the kerl/dataframe-shape-temp branch from 2ab86e1 to 086cf3e Compare November 5, 2024 16:21
@johnkerl johnkerl force-pushed the kerl/notebook-new-shape-refresh branch from 01473ca to 71668ec Compare November 5, 2024 16:22
@johnkerl johnkerl force-pushed the kerl/dataframe-shape-temp branch from 086cf3e to a592f3a Compare November 5, 2024 17:12
@johnkerl johnkerl force-pushed the kerl/notebook-new-shape-refresh branch from 71668ec to c37833b Compare November 5, 2024 17:12
@johnkerl johnkerl requested a review from nguyenv November 5, 2024 22:08
@johnkerl johnkerl marked this pull request as draft November 5, 2024 22:08
@johnkerl
Copy link
Member Author

johnkerl commented Nov 5, 2024

Converting to draft while I rework the data storage on a separate PR

@johnkerl johnkerl force-pushed the kerl/notebook-new-shape-refresh branch 3 times, most recently from 5f5d2a7 to bd5ab54 Compare November 5, 2024 23:10
@johnkerl
Copy link
Member Author

johnkerl commented Nov 5, 2024

@aaronwolen re-requesting review as this is now rebased on top of #3295 (which has been merged).

@johnkerl johnkerl force-pushed the kerl/notebook-new-shape-refresh branch from bd5ab54 to 20d4831 Compare November 5, 2024 23:12
@johnkerl johnkerl changed the base branch from kerl/dataframe-shape-temp to main November 5, 2024 23:12
@johnkerl johnkerl marked this pull request as ready for review November 5, 2024 23:13
* Geometry dataframe implementation, use spatial axes when available when creating schema

* Address PR review comments
@johnkerl johnkerl force-pushed the kerl/notebook-new-shape-refresh branch from 20d4831 to 23953ae Compare November 6, 2024 15:52
@johnkerl johnkerl merged commit 33b104c into main Nov 6, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/notebook-new-shape-refresh branch November 6, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants