-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Re-run, and update, example notebooks with new shape feature #3290
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3290 +/- ##
==========================================
+ Coverage 85.29% 85.40% +0.10%
==========================================
Files 52 52
Lines 5517 5517
==========================================
+ Hits 4706 4712 +6
+ Misses 811 805 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
58b711c
to
01473ca
Compare
2ab86e1
to
086cf3e
Compare
01473ca
to
71668ec
Compare
086cf3e
to
a592f3a
Compare
71668ec
to
c37833b
Compare
Converting to draft while I rework the data storage on a separate PR |
5f5d2a7
to
bd5ab54
Compare
@aaronwolen re-requesting review as this is now rebased on top of #3295 (which has been merged). |
bd5ab54
to
20d4831
Compare
* Geometry dataframe implementation, use spatial axes when available when creating schema * Address PR review comments
20d4831
to
23953ae
Compare
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Re-execute our notebooks with the new-shape feature. Change the wording in many places to remove needless complexities from the pre-shape era.
This PR affects existing notebooks. There is a separate PR with a new notebook dedicated to the new shape feature: #3294.
Notes for Reviewer:
This PR was run on a system with core
dev
(2.27-to-be) installed on it.Handy review link with rendered notebooks:
https://github.com/single-cell-data/TileDB-SOMA/tree/kerl/notebook-new-shape-refresh/apis/python/notebooks