Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Use AnnData 0.10.1 #1784

Merged
merged 2 commits into from
Oct 11, 2023
Merged

[python] Use AnnData 0.10.1 #1784

merged 2 commits into from
Oct 11, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 11, 2023

Issue and/or context: As in #1765. There is now a 0.10.1 which solves the problem (we were not the only ones to suffer). See also #1785 for longer-term follow-up (next year).

Changes:

Notes for Reviewer:

apis/python/setup.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

see 76 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@johnkerl johnkerl merged commit ec86bf6 into main Oct 11, 2023
9 checks passed
@johnkerl johnkerl deleted the kerl/anndata-0-10-1 branch October 11, 2023 20:24
Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a need to make the same change to the somacore dependencies?

@johnkerl
Copy link
Member Author

@bkmartinjr no

@johnkerl
Copy link
Member Author

Not affected AFAIK

github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
* [python] Use AnnData 0.10.1

* code-review feedback
johnkerl added a commit that referenced this pull request Oct 11, 2023
* [python] Use AnnData 0.10.1

* code-review feedback

Co-authored-by: John Kerl <[email protected]>
@thetorpedodog
Copy link
Contributor

Not affected AFAIK

This is correct; we don’t play with any anndata internals in somacore, so it has no restrictions in and of itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants