Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracker] Depend on AnnData 0.10, and not less #1785

Closed
johnkerl opened this issue Oct 11, 2023 · 1 comment
Closed

[tracker] Depend on AnnData 0.10, and not less #1785

johnkerl opened this issue Oct 11, 2023 · 1 comment
Assignees

Comments

@johnkerl
Copy link
Member

Details on #1765 and #1784.

TL;DR:

  • Before 0.10.0 there was anndata._core.sparse_dataset.SparseDataset
  • In 0.10.0 there was anndata._core.sparse_dataset.CSRDataset and anndata._core.sparse_dataset.CSCDataset
  • As found on [python] Temporarily pin to AnnData 0.9.* #1765 we can't do typeguard checking with version-based if-statements in them
  • So on [python] Temporarily pin to AnnData 0.9.* #1766 we pinned to < 0.10.0
  • In 0.10.1 there is again anndata._core.sparse_dataset.SparseDataset so we're in the clear
  • But in 2024-ish that will be deprecated again
  • At that point in time we should simply pin to AnnData >= 0.10.1 and use the new CSRDataset/CSCDataset exclusively
@johnkerl
Copy link
Member Author

johnkerl commented Apr 8, 2024

Also depends on #2141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant