-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Support new set-membership query condition #1756
Conversation
The unit-test case is failing because of this, needing to be fixed: Before:
After:
That is to say, we need to preserve the feature that the queried-for attribute name gets included in the list of output attrs. See #755 for reference. |
Codecov ReportAll modified lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. see 36 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
40ecade
to
0551b17
Compare
c1d7614
to
a703226
Compare
(BTW the aforementioned unit-test case has since been fixed) |
CI fail
as AnnData 0.10.0 dropped today: |
Before:
After:
|
5c01308
to
bffe837
Compare
This is stacked atop the blocking PR #1766 until that PR is merged, at which point this PR will be on |
bffe837
to
04d25fe
Compare
1a95736
to
21ac225
Compare
04d25fe
to
65024c0
Compare
21ac225
to
9d4c0a0
Compare
9b469a8
to
30cf2d6
Compare
Update: this PR was a very simple copy of TileDB-Inc/TileDB-Py#1837 Along the way we ran into the following, which were fixed: So this should now be a very simple approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor thing that you might want to address before submitting but not a showstopper.
42a0cd8
to
07cb4ca
Compare
* [python] Support new set-membership query condition * unit-test coverage for not-in * code-review feedback * lint * attempt to work around anndata 0.10.0 [WIP] * undo anndata 0.10.0 attempted workaround; code-review feedback
* [python] Support new set-membership query condition * unit-test coverage for not-in * code-review feedback * lint * attempt to work around anndata 0.10.0 [WIP] * undo anndata 0.10.0 attempted workaround; code-review feedback Co-authored-by: John Kerl <[email protected]>
Issue and/or context: This is an adaptation of PR TileDB-Inc/TileDB-Py#1837 for issue #1742