Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Sync TileDB-Py and TileDB-SOMA Python query-condition code #1667

Closed
nguyenv opened this issue Sep 11, 2023 · 2 comments
Closed

[python] Sync TileDB-Py and TileDB-SOMA Python query-condition code #1667

nguyenv opened this issue Sep 11, 2023 · 2 comments

Comments

@nguyenv
Copy link
Member

nguyenv commented Sep 11, 2023

There have been several indepedent updates to the query condition code in TileDB-Py and TileDB-SOMA Python APIs that should be synced. Divergence has been introduced by both repos. For example, although the TileDB-Py code has support for query conditions on dimensions and Boolean types, these are still missing in TileDB-SOMA. On the other end, TileDB-SOMA has been updated to use attrs but TileDB-Py still uses dataclasses.

@johnkerl johnkerl changed the title [python] Sync TileDB-Py and TileDB-SOMA Python Query Condition Code [python] Sync TileDB-Py and TileDB-SOMA Python query-condition code Oct 10, 2023
@johnkerl
Copy link
Member

@nguyenv did #1756 achieve this goal, as a side effect?

@nguyenv
Copy link
Member Author

nguyenv commented Oct 23, 2023

No, and in fact both #1756 and #1793 have introduced more divergences from the TileDB-Py code. For example, init_query_condition take in completely different arguments, and the TileDB-SOMA code retrieves info from a passed in ArrowSchema instead of TileDB ArraySchema (good because this means we getting rid of TileDB-Py dependencies in the SOMA code). This issue should probably be closed since the query condition codes are too different at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants