Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Travis workflow to GH actions #554

Merged
merged 11 commits into from
Jul 28, 2021
Merged

Conversation

robertopreste
Copy link
Contributor

Closes #553

This PR replaces Travis CI with GitHub Actions.
At the moment, some Selenium tests are failing, will need to investigate why.

@robertopreste robertopreste marked this pull request as ready for review July 27, 2021 07:23
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #554 (93527ce) into master (15d2aeb) will decrease coverage by 0.16%.
The diff coverage is 40.00%.

❗ Current head 93527ce differs from pull request most recent head d8ec906. Consider uploading reports for the commit d8ec906 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   95.26%   95.10%   -0.17%     
==========================================
  Files          86       92       +6     
  Lines        4015     4168     +153     
  Branches      252      269      +17     
==========================================
+ Hits         3825     3964     +139     
- Misses        136      144       +8     
- Partials       54       60       +6     
Impacted Files Coverage Δ
remoteappmanager/docker/tests/test_container.py 100.00% <ø> (ø)
remoteappmanager/docker/container.py 90.47% <40.00%> (-4.53%) ⬇️
remoteappmanager/tests/test_user.py 100.00% <0.00%> (ø)
remoteappmanager/tests/test_application.py 100.00% <0.00%> (ø)
remoteappmanager/user.py 100.00% <0.00%> (ø)
remoteappmanager/utils.py 81.35% <0.00%> (ø)
remoteappmanager/__init__.py 100.00% <0.00%> (ø)
remoteappmanager/application.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d2aeb...d8ec906. Read the comment docs.

Copy link
Contributor

@flongford flongford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @robertopreste! In general LGTM - my questions are mainly around understanding the changes to the container ports handling.

remoteappmanager/docker/container.py Show resolved Hide resolved
@flongford flongford merged commit 4b07ecd into master Jul 28, 2021
@flongford flongford deleted the 553-travis-to-gh-actions branch July 28, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use GitHub Actions for CI
3 participants