Skip to content

Commit

Permalink
Add note explaining docker dict details for GH actions
Browse files Browse the repository at this point in the history
  • Loading branch information
Roberto Preste committed Jul 27, 2021
1 parent 93527ce commit d8ec906
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions remoteappmanager/docker/container.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ def from_docker_dict(cls, docker_dict):
>>> containers = docker.Client().containers()
>>> Container.from_docker_dict(containers[0])
Notes
-----
On GitHub Actions, the Ports key of the docker dict contains two
elements, with the first one having the proper HostIp and the other
having a '::' HostIp. We can safely assume the first one is the valid
one, and raise an exception in any other case.
"""

is_inspect_container_output = ("Config" in docker_dict)
Expand Down

0 comments on commit d8ec906

Please sign in to comment.