NEW Add onBeforeRemoveLoginSession extension hook #34
+10
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2021
Closed
emteknetnz
force-pushed
the
pulls/1/auditor
branch
3 times, most recently
from
079a423 to
05b45a1
Compare
emteknetnz
force-pushed
the
pulls/1/auditor
branch
from
05b45a1 to
fa8c641
Compare
emteknetnz
force-pushed
the
pulls/1/auditor
branch
2 times, most recently
from
f13cc34 to
a1ac0a9
Compare
emteknetnz
force-pushed
the
pulls/1/auditor
branch
from
a1ac0a9 to
0cea6ef
Compare
bergice
suggested changes
Mar 24, 2021
| class LoginSessionController extends LeftAndMain | ||
| { | ||
| private static $url_segment = 'loginsession'; | ||
|
|
||
| // TODO: this is probably a legacy config that's not used anywhere so should be deleted |
There was a problem hiding this comment.
Nope, without it, this will show up in the sidebar.
There was a problem hiding this comment.
Ah OK, it's because this extends LeftAndMain instead of Controller
I've updated the TODOs to change what this inherits from, and also move the folder
I'd do it on this PR, except I don't want to mix up features + refactoring on the same PR, and it may cause merge conflicts on other open PR's. I've created a new issue to track this #42
emteknetnz
force-pushed
the
pulls/1/auditor
branch
from
0cea6ef to
5a6b0d0
Compare
|
@bergice this is ready for review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #20
Related: silverstripe/silverstripe-auditor#37
I've implemented this as a
onBeforerather than anonAfterto ensure data is still available to record in the auditor log