Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder/namespace renaming #42

Closed
8 tasks done
emteknetnz opened this issue Mar 28, 2021 · 1 comment
Closed
8 tasks done

Folder/namespace renaming #42

emteknetnz opened this issue Mar 28, 2021 · 1 comment
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Mar 28, 2021

Should do this close to the conclusion of the feature dev so as not to cause any merge conflicts with open PRs

ACs

  • Move contents of Extension folder to the Extensions folder and ensure namespace matches
  • Pluralise the following folders/namespaces to match the other folders - FormField, Job, Model, Service
  • Create Controllers folder, move LoginSessionController there, update namespace from /Control/ to /Controllers/
  • LoginSessionController - change class it extends from LeftAndMain to Controller, remove $ignore_menuitem config
  • Change LoginSessionMiddleware namespace from /Control/ to /Middleware/
  • Double check all other namespaces match folders
  • Remove unused class SilverStripe\SessionManager\Forms\GridFieldRevokeLoginSessionAction

PRs

@emteknetnz emteknetnz changed the title Folder + extends refactoring Folder/namespace renaming + update LoginSessionController Mar 28, 2021
@emteknetnz emteknetnz assigned emteknetnz and unassigned emteknetnz Mar 28, 2021
@emteknetnz emteknetnz changed the title Folder/namespace renaming + update LoginSessionController Folder/namespace renaming Mar 29, 2021
@maxime-rainville
Copy link

I've added an AC to remove the unused class SilverStripe\SessionManager\Forms\GridFieldRevokeLoginSessionAction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants