Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Update folders + namespaces, remove unused class #74

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

emteknetnz
Copy link
Member

Issue #42

@emteknetnz emteknetnz mentioned this pull request Jun 9, 2021
8 tasks
@emteknetnz emteknetnz force-pushed the pulls/1/namespacing branch from cd953d4 to 4fd81e9 Compare June 9, 2021 01:04
@emteknetnz emteknetnz force-pushed the pulls/1/namespacing branch from 4fd81e9 to b8afcdd Compare June 9, 2021 01:21
Copy link
Contributor

@bergice bergice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Causes a fatal error if there are LoginSessions existing already before applying this as it's processing them in the middleware: [Emergency] Uncaught SilverStripe\ORM\ValidationException: Object is of class 'SilverStripe\SessionManager\Model\LoginSession' which doesn't exist - you need to change the ClassName before you can write it.
Might be okay if no one is using the module yet.

After removing LoginSessions from the database, I'm getting this error: [Emergency] Uncaught Error: Call to undefined method SilverStripe\Security\RememberLoginHash::setLogoutAcrossDevices(). Not sure why this method is gone.
Seems like it should now be RememberLoginHash::config()->update('logout_across_devices', false);

@emteknetnz
Copy link
Member Author

emteknetnz commented Jun 10, 2021

@bergice you probably need to run composer update - basically you want to be runing 4.8 on your local - there was new API added to framework RememberLoginHash::setLogoutAcrossDevices() and the requirement withing session-manager was bumped to "silverstripe/framework": "^4.8",

The new API was added specifically so we did not run RememberLoginHash::config()->update('logout_across_devices', false) which is messy as you're changing a framework config directly from a satellite module

@bergice bergice merged commit ab22524 into silverstripe:1 Jun 10, 2021
@maxime-rainville maxime-rainville deleted the pulls/1/namespacing branch June 11, 2021 04:59

// TODO: move this to Controllers folder and extend Controller instead of LeftAndMain
class LoginSessionController extends LeftAndMain
class LoginSessionController extends Controller

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emteknetnz @bergice Changing this class from LeftAndMain to Controller completely nukes the functionality. I understand this is a big PR, but you should at least try to run these things before merging them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it through #67

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it was my screw up. I change something else on my set up ... just ignore me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants