NEW Support for session-manager module #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2021
Merged
emteknetnz
force-pushed
the
pulls/2/session-manager-hook
branch
3 times, most recently
from
0ca2278 to
8288a7e
Compare
bergice
suggested changes
Mar 24, 2021
emteknetnz
force-pushed
the
pulls/2/session-manager-hook
branch
from
8288a7e to
698c495
Compare
|
@bergice this is ready for review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-session-manager#20
Related silverstripe/silverstripe-session-manager#34 <- session-manager PR needs to be merged before this PR will work
If wondering why the extension hook is on this module rather than on session manager, I wrote an explanation here tl;dr to be consistent with other extension hook on the auditor module