Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix using treedropdownfield in behat #10635

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jan 8, 2023

Fixes an error from https://github.com/silverstripe/silverstripe-cms/actions/runs/3726652553/jobs/6320241058

Unable to find the dropdown in "#Form_AddForm_ParentID_Holder"

Also fixes a subsequent failure where an element that contained the text (but wasn't the actual option) tried to get clicked instead. This is resolved by looking for the exact text, rather than using contains.

Parent issue

@GuySartorelli GuySartorelli changed the title MNT Use correct selector for treedropdownfield in behat MNT Fix using treedropdownfield in behat Jan 10, 2023
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 2868edd into silverstripe:5 Jan 10, 2023
@maxime-rainville maxime-rainville deleted the pulls/5/fix-behat branch January 10, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants