Fix anchor select field component #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been done when we upgraded react-select. My bad.
This was referenced Jan 9, 2023
GuySartorelli
commented
Jan 11, 2023
| @@ -95,6 +95,7 @@ class AnchorSelectorField extends SilverStripeComponent { | |||
| * @param {String} value | |||
| */ | |||
| handleChange(value) { | |||
| console.log(value); | |||
There was a problem hiding this comment.
Suggested change
| console.log(value); |
Oops I need to remove this
|
Marking this as DRAFT as it requires silverstripe/webpack-config#55 to be merged, tagged, and published in npm before I can add the emotion cache component. |
|
The changes to |
This ensures we can override the react-select CSS if we need to.
GuySartorelli
force-pushed
the
pulls/5/fix-behat2
branch
from
db48c50 to
ef4122d
Compare
|
Note that this PR now requires silverstripe/silverstripe-admin#1432 to be merged before it will go "green" (behat will still fail, but the tests that this PR specifically is targetting should pass) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been done when we upgraded react-select. My bad. The
Creatablecomponent is replaced withCreatableSelectand along with changes to that component's props, the selectors have also changed.Fixes part of https://github.com/silverstripe/silverstripe-cms/actions/runs/3726652553/jobs/6320241058
Note
Requires silverstripe/silverstripe-framework#10635 as well, as the affected behat tests also include interacting with tree dropdowns.
Parent issue