MNT Fix behat test for inserting WYSIWYG links #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The selectors for TreeDropdownField's markup changed when we updated react-select.
maxime-rainville
requested changes
Jan 11, 2023
There was a problem hiding this comment.
silverstripe/silverstripe-framework#10635 has been merged but the behat build is still failing. Is that expected?
|
@maxime-rainville There are two separate PRs to handle silverstripe/cms behat tests. Some of them are fixed by this PR and some are fixed by #2813 You should see that each PR has different tests failing (i.e. some failures have dropped off the original set of failed tests), which indicates that when they're both merged they'll all be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of https://github.com/silverstripe/silverstripe-cms/actions/runs/3726652553/jobs/6320241058
The selectors for TreeDropdownField's markup changed when we updated react-select.
Note
Requires silverstripe/silverstripe-framework#10635 as well.
Parent issue