FIX Cast possibly null link to string #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still failing ci? |
emteknetnz
force-pushed
the
pulls/5/broken-builds
branch
from
b4645dc to
f7cc9f2
Compare
This was referenced Dec 8, 2022
emteknetnz
force-pushed
the
pulls/5/broken-builds
branch
from
f7cc9f2 to
4cf4027
Compare
|
Was that API change documented? I can't find it in the changelog. |
|
Got changed because signature was strongly typed due to a deprecated param Not documented - plan is to do all the API changes in one big go - https://github.com/silverstripeltd/product-issues/issues/627 |
|
Okay. I wasn't aware of that (I thought that was only going to be for the deleted API) so it's probably worth mentioning that either in standup or in slack so the whole team is across that approach. But that's fine. |
GuySartorelli
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
See silverstripe/silverstripe-cms#2806 (comment) for a discussion on this approach. Strongly typing the return type of the given methods is out of scope for CMS 5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripeltd/product-issues/issues/642
Fixes
ERROR [Emergency]: Uncaught TypeError: SilverStripe\Control\Director::absoluteURL(): Argument #1 ($url) must be of type string, null given, called in /home/runner/work/silverstripe-graphql/silverstripe-graphql/vendor/dnadesign/silverstripe-elemental/src/Models/BaseElement.php on line 940https://github.com/silverstripe/silverstripe-graphql/actions/runs/3645001687/jobs/6154761063#step:10:1226
Exception happens during
dev/build- api change onDirector::absoluteUrl()means null is no longer accepted