Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Cast absoluteUrl() argument to string #532

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 8, 2022

@emteknetnz emteknetnz force-pushed the pulls/2/absolute-link branch from a8d58a4 to 8a9da87 Compare December 8, 2022 21:01
@emteknetnz emteknetnz force-pushed the pulls/2/absolute-link branch from 8a9da87 to 459d421 Compare December 8, 2022 21:03
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See silverstripe/silverstripe-cms#2806 (comment) for a discussion on this approach

@GuySartorelli GuySartorelli merged commit c10dd20 into silverstripe:2 Dec 13, 2022
@GuySartorelli GuySartorelli deleted the pulls/2/absolute-link branch December 13, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants