FIX Cast absoluteUrl() argument to string #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/2/absolute-link
branch
from
b018af8 to
5b0197f
Compare
emteknetnz
force-pushed
the
pulls/2/absolute-link
branch
from
5b0197f to
379ddb5
Compare
GuySartorelli
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
See silverstripe/silverstripe-cms#2806 (comment) for a discussion on this approach - it'd be nicer for AssetAdmin::getFileEditLink() to always return a string, but strong-typing is out of scope for now (ironically, given strongly typing caused the problem in the first place)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripeltd/product-issues/issues/642
Similar to silverstripe/silverstripe-elemental#1029