Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: send bundles to Flashbots #183

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Feat: send bundles to Flashbots #183

merged 2 commits into from
Aug 22, 2023

Conversation

da-bao-jian
Copy link
Contributor

RE: #165

@da-bao-jian da-bao-jian mentioned this pull request Aug 6, 2023
Merged
@zsluedem
Copy link
Collaborator

zsluedem commented Aug 6, 2023

You could use git rebase to clean up your branch

Vid201
Vid201 reviewed Aug 8, 2023
View reviewed changes
bin/silius/src/silius.rs Outdated Show resolved Hide resolved
Vid201
Vid201 requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! left some smaller things to address

@Vid201 Vid201 linked an issue Aug 19, 2023 that may be closed by this pull request
Send bundles (txs) to Flashbots #11
Closed
@da-bao-jian
Copy link
Contributor Author

Sorry took a little longer than expected. Mostly was resolving dependency conflicts and rebasing commits.

Vid201
Vid201 requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comments from my side!

bin/silius/src/silius.rs Outdated Show resolved Hide resolved
crates/primitives/src/chain.rs Outdated Show resolved Hide resolved
bin/silius/src/cli.rs Outdated Show resolved Hide resolved
bin/silius/src/cli.rs Show resolved Hide resolved
@Vid201 Vid201 merged commit ea49b42 into silius-rs:main Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vid201 Vid201 Vid201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send bundles (txs) to Flashbots
3 participants
@da-bao-jian @zsluedem @Vid201