Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc for crate/rpc crate #184

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Rustdoc for crate/rpc crate #184

merged 1 commit into from
Aug 8, 2023

Conversation

da-bao-jian
Copy link
Contributor

RE: #168

@da-bao-jian
Copy link
Contributor Author

da-bao-jian commented Aug 6, 2023

Looks like this PR and #183 are both failing the same test in Run bundler spec tests (pull_request) ci

It's werid because this PR in particular didn't touch any real code, but only added some comments

@zsluedem
Copy link
Collaborator

zsluedem commented Aug 7, 2023

@da-bao-jian
@Vid201 already submit a pr to fix it #185. Let's wait for the pr to be merged first.

Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tnx

Just some nitpicks

crates/rpc/README.md Outdated Show resolved Hide resolved
crates/rpc/README.md Outdated Show resolved Hide resolved
crates/rpc/src/error.rs Outdated Show resolved Hide resolved
@Vid201 Vid201 merged commit 1ec9ad6 into silius-rs:main Aug 8, 2023
2 checks passed
@Vid201
Copy link
Member

Vid201 commented Aug 8, 2023

Thanks!

@da-bao-jian da-bao-jian deleted the doc/rpc branch August 12, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants