[WIP]Send bundles (txs) to Flashbots #165

da-bao-jian · 2023-07-18T04:38:20Z

Description

Sending bundles to Flashbot's Relay has the benefit of avoiding front-run and sandwich attacks. Currently, the bundler only supports sending transaction bundles through the public mempool, which is vulnerable to the said attacks above. As the volume of UserOperations picks up, each bundle submitted will likely generate more MEV, hence attracting more MEV bots.

Allowing the bundlers to submit bundles through Flashbots has the following benefits:

Avoiding the malicious MEV attacks from the public mempool
Paving the way to support more MEV-related features, such as MEV-protect and MEV-Share

Things changed

crates/bundler/.env.example

Added FLASHBOTS_IDENTIFIER as it is required by Flashbots(see How to send your first Flashbots bundle)

crates/bundler/Cargo.toml

Added ethers-flashbot, url, tokio crates to support functionalities in the send_next_bundle_flashbots function

crates/bundler/src/bundler.rs

Added the RELAY_ENDPOINTS for most of the commonly used block builder endpoint
Added the send_next_bundle_flashbots function

Pending Issues

There is no good way to test sending bundle using Flashbots unless a remote endpoint is used, such as Flashbots' Bundle Relay API on Goerli or Sepolia

zsluedem

Left some comments

crates/bundler/src/bundler.rs

Vid201 · 2023-07-24T18:12:30Z

crates/bundler/Cargo.toml

@@ -17,3 +17,6 @@ aa-bundler-primitives = { path = "../primitives" }
 anyhow = "1"
 ethers = { workspace = true }
 tracing = { workspace = true }
+ethers-flashbots = "0.13.1"


what are the formatting and sorting rules for Cargo.toml

Even if I sorted the deps alphabetically, it when run make lint it still says not sorted

Hmm, it should be alphabetically and nothing else. Is there any error text?

error: Cargo.toml for bundler is not formatted Checking bundler... error: Dependencies for bundler are not sorted Checking contracts... Checking grpc... Checking primitives... Checking rpc... Checking uopool... Checking examples... error: Cargo.toml for examples is not formatted

If you check the example/Cargo.tomal, and bin/bundler/Cargo.toml in the latest commit, they should be alphabetically sorted.

It's not sorted because tokio should be before tracing

crates/bundler/src/bundler.rs

Vid201 · 2023-07-25T17:34:05Z

examples/Cargo.toml

+
+
+[dependencies]
+jsonrpsee = {version = "0.18.2", features = ["server", "http-client"]}


Is not formatted error is because features are not sorted and there is no whitespace between {version -> { version and "http-client"]} -> "http-client"] }

Thanks for pointing it out!

I've added cargo sort --workspace command to the Makefile in the latest commit. Otherwise, it's a pain in the ass to sort & format deps manually.

Yeah, that makes sense, cool

Vid201 · 2023-07-25T17:35:04Z

crates/bundler/Cargo.toml

@@ -17,3 +17,6 @@ aa-bundler-primitives = { path = "../primitives" }
 anyhow = "1"
 ethers = { workspace = true }
 tracing = { workspace = true }
+ethers-flashbots = "0.13.1"


It's not sorted because tokio should be before tracing

da-bao-jian · 2023-07-25T21:46:26Z

For the latest update, other than addressing the previous issues, I also added some comments for Rustdoc generation. Let me know what you think so that I could know if it's the correct format to go about adding rustdocs to other files. @Vid201

Vid201 · 2023-07-26T07:24:54Z

For the latest update, other than addressing the previous issues, I also added some comments for Rustdoc generation. Let me know what you think so that I could know if it's the correct format to go about adding rustdocs to other files. @Vid201

Hey, I checked and it looks good, it would be perfect to have that

bin/bundler/src/bundler.rs

crates/primitives/src/consts.rs

Vid201 · 2023-07-26T15:02:35Z

crates/grpc/src/bundler.rs

@@ -49,6 +49,7 @@ impl BundlerService {
        Ok(uos)
    }

+    // TODO: add send bundle to flashbots


add CLI mode: ./bundler --send-bundle flashbots or ./bundler --send-bundle eth-client

For this, here's how I could implement it

add the send-bundle command in bin/bundler/bundler. If flashbots, bundler should use the send_next_bundle_flashbots method by default. There are three places I could indicate the intent to send bundle via flashbots

adding an additional field to the send_bundle function

adding an additional field to the Bundler struct;

adding an additional field to the bundler_service_run

Let me know which is the best option

I would make SendBundleMode enum and add an additional field to the Bundler struct. Enum is parsed from CLI and passed as an additiona field to the bundler_service_run which pushes it to the Bundler struct constructor.

da-bao-jian · 2023-07-27T03:46:53Z

As for testing, do you have any suggestions?

I could use flashbots builder on Goerli, but this requires Goerli ETH. In other words, not everyone is able to pass the test if he/she doesn't have Goerli ETH.

Alternatively, I could send an eth_simulate request. If the payload indicates success, it'll pass the test. I believe simulation requires no real payment.

Vid201 · 2023-07-27T07:10:38Z

As for testing, do you have any suggestions?

I could use flashbots builder on Goerli, but this requires Goerli ETH. In other words, not everyone is able to pass the test if he/she doesn't have Goerli ETH.

Alternatively, I could send an eth_simulate request. If the payload indicates success, it'll pass the test. I believe simulation requires no real payment.

Makes sense. I think simulating is enough for the tests. Do you mean this endpoint: https://docs.flashbots.net/flashbots-auction/searchers/advanced/rpc-endpoint#eth_callbundle ?

We can also have a test that is skipped during CI, but has to be manually run.

zsluedem requested changes Jul 19, 2023

View reviewed changes

crates/bundler/src/bundler.rs Outdated Show resolved Hide resolved

crates/bundler/src/bundler.rs Outdated Show resolved Hide resolved

crates/bundler/src/bundler.rs Outdated Show resolved Hide resolved

crates/bundler/src/bundler.rs Outdated Show resolved Hide resolved

Vid201 requested changes Jul 24, 2023

View reviewed changes

Vid201 linked an issue Jul 24, 2023 that may be closed by this pull request

Send bundles (txs) to Flashbots #11

Closed

da-bao-jian marked this pull request as ready for review July 25, 2023 04:44

Vid201 requested changes Jul 25, 2023

View reviewed changes

Vid201 requested changes Jul 26, 2023

View reviewed changes

bin/bundler/src/bundler.rs Outdated Show resolved Hide resolved

crates/primitives/src/consts.rs Outdated Show resolved Hide resolved

Vid201 reviewed Jul 26, 2023

View reviewed changes

da-bao-jian closed this Aug 5, 2023

da-bao-jian force-pushed the main branch from 47f8958 to d0399c3 Compare August 5, 2023 08:22

This was referenced Aug 5, 2023

Send bundles (txs) to Flashbots #182

Closed

Feat: send bundles to Flashbots #183

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP]Send bundles (txs) to Flashbots #165

[WIP]Send bundles (txs) to Flashbots #165

da-bao-jian commented Jul 18, 2023 •

edited

Loading

zsluedem left a comment

Vid201 Jul 24, 2023

da-bao-jian Jul 25, 2023

Vid201 Jul 25, 2023

da-bao-jian Jul 25, 2023

Vid201 Jul 25, 2023

Vid201 Jul 25, 2023

da-bao-jian Jul 25, 2023 •

edited

Loading

Vid201 Jul 25, 2023

Vid201 Jul 25, 2023

da-bao-jian commented Jul 25, 2023

Vid201 commented Jul 26, 2023

Vid201 Jul 26, 2023

da-bao-jian Jul 27, 2023

Vid201 Jul 27, 2023

da-bao-jian commented Jul 27, 2023 •

edited

Loading

Vid201 commented Jul 27, 2023



		[dependencies]
		jsonrpsee = {version = "0.18.2", features = ["server", "http-client"]}

[WIP]Send bundles (txs) to Flashbots #165

[WIP]Send bundles (txs) to Flashbots #165

Conversation

da-bao-jian commented Jul 18, 2023 • edited Loading

Description

Things changed

Pending Issues

zsluedem left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

da-bao-jian Jul 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

da-bao-jian commented Jul 25, 2023

Vid201 commented Jul 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

da-bao-jian commented Jul 27, 2023 • edited Loading

Vid201 commented Jul 27, 2023

da-bao-jian commented Jul 18, 2023 •

edited

Loading

da-bao-jian Jul 25, 2023 •

edited

Loading

da-bao-jian commented Jul 27, 2023 •

edited

Loading