-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rekor get tlog entry with uuid #2058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!!
Codegen or a rebase issue? |
I think an issue with compiling cosign, we might need to update to 1.18:
|
yeah, i'm seeing some problems when i run codegen locally as well. is this because rekor is at 1.18? |
I think that |
ah nice find! i'll open a PR to bump to 1.18 edit: pending #2059 |
0cdc392
to
0e3f70f
Compare
0e3f70f
to
0aacab8
Compare
Confirmed this fixes goreleaser:
|
@priyawadhwa @dlorenc @hectorj2f sorry this got lost after the golang bump! but this will fix the recent goreleaser issue so I am reviving it. |
0aacab8
to
cbd8505
Compare
Once again I have some dep problems... :/ |
cbd8505
to
609e630
Compare
You should be able to rebase now! |
609e630
to
8ec6b22
Compare
Updated, thank you! Note the comment in the dep check: If needed, I'll see if I can split up the sharding package's sharding computation from the stuff that requires Trillian clients. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally prefer to not pull that in as it has caused (well, not Trillian alone, but things with glog and other huge deps. My preference would be (I can't believe I'm saying this ;) ) cut&paste. When you say it would be wip for little time, what's the actual fix that we would have to do? But from this PR I don't quite get why we need to comment out the trillian bit, this doesn't seem to bring in new deps added, so I don't understand why we need to remove it. |
Also, I know folks are sensitive to deps and sizes (I know when I inadvertently pulled in something that had a k8s dep :) ) |
The In fact, only needs the Trillian LogClient, and only that to have the method Another option would be to define a new interface Or, as @vaikas says, copy and paste |
Yeah exactly. I could either do this, since it's not complicated logic, but my main idea was to separate these sharding utils from the sharding code that manipulates and requires the trillian log client. I'll resolve it internally. Before GA we will expose verification libraries with few deps in rekor anyway. And that will supersede all this code. |
8ec6b22
to
8dd1212
Compare
All set, PTAL. Added tests for all the cases of whether Rekor will return EntryUUIDs or UUIDs to make sure matching occurs correctly. |
Looks like lint failures, feel free to either fix or skip for the copy/pasta'd code. |
Signed-off-by: Asra Ali <[email protected]> update sharding Signed-off-by: Asra Ali <[email protected]> lint Signed-off-by: Asra Ali <[email protected]>
8dd1212
to
2241aef
Compare
Signed-off-by: Asra Ali <[email protected]> update sharding Signed-off-by: Asra Ali <[email protected]> lint Signed-off-by: Asra Ali <[email protected]> Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali [email protected]
Sign blob w/ search otherwise doesn't work, because the UUID in the response of Rekor now includes a prefix shard UUID.
cc @priyawadhwa
Summary
Release Note
Documentation
Fixes #1406