Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests using Go 1.18 #2093

Merged
merged 2 commits into from
Aug 14, 2022
Merged

Run tests using Go 1.18 #2093

merged 2 commits into from
Aug 14, 2022

Conversation

imjasonh
Copy link
Member

Summary

Go 1.19 will be out next month, which means Go 1.17 will be out of support.

Signed-off-by: Jason Hall [email protected]

Release Note

NONE

Documentation

NONE

Signed-off-by: Jason Hall <[email protected]>
cpanato
cpanato previously approved these changes Jul 22, 2022
@imjasonh
Copy link
Member Author

This hits #2091 😢

@cpanato
Copy link
Member

cpanato commented Jul 27, 2022

this is something we can enable only for the tests or does that affects the binary when users use this feature?

@imjasonh
Copy link
Member Author

this is something we can enable only for the tests or does that affects the binary when users use this feature?

I think we could GODEBUG=x509sha1=1 for tests, and rely on e2e tests to tell us whether this causes any issues in the actual CLI usage.

Just building cosign from HEAD with Go 1.18 and testing locally, I'm able to COSIGN_EXPERIMENTAL=1 cosign sign && cosign verify an image, so at least that much seems to work.

@asraa
Copy link
Contributor

asraa commented Aug 5, 2022

quick ping on this if possible? it's blocking upgrading rekor so we can handle some incompatible rekor changes that prevent blob verification #2058

@imjasonh
Copy link
Member Author

imjasonh commented Aug 6, 2022

My understanding is we can either update our usage of the deprecated SHA-1 cert (#2091 (comment)) or temporarily set the env var to ignore it during tests.

If you're blocked I'd say set the env var in tests and upgrade to Go 1.18+ to get unblocked.

@dlorenc
Copy link
Member

dlorenc commented Aug 14, 2022

Added the suppression, this can unblock a few pending PRs.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2022

Codecov Report

Merging #2093 (641d445) into main (95b74db) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2093      +/-   ##
==========================================
- Coverage   26.33%   26.23%   -0.11%     
==========================================
  Files         129      130       +1     
  Lines        7564     7617      +53     
==========================================
+ Hits         1992     1998       +6     
- Misses       5317     5362      +45     
- Partials      255      257       +2     
Impacted Files Coverage Δ
pkg/oci/static/file.go 64.70% <0.00%> (-5.30%) ⬇️
pkg/oci/mutate/signatures.go 33.33% <0.00%> (-0.67%) ⬇️
pkg/policy/eval.go 78.94% <0.00%> (-0.54%) ⬇️
pkg/cosign/rego/rego.go 70.96% <0.00%> (-0.47%) ⬇️
cmd/cosign/cli/verify/verify_blob.go 9.72% <0.00%> (-0.16%) ⬇️
cmd/cosign/cli/sign/sign.go 14.57% <0.00%> (-0.13%) ⬇️
pkg/cosign/tlog.go 30.07% <0.00%> (ø)
pkg/cosign/fetch.go 0.00% <0.00%> (ø)
cmd/cosign/cli/sign.go 0.00% <0.00%> (ø)
cmd/cosign/cli/attach.go 0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dlorenc
dlorenc previously approved these changes Aug 14, 2022
We should fix this with new testdata but we're blocked on an
upstream change.

Signed-off-by: Dan Lorenc <[email protected]>
@dlorenc dlorenc merged commit 112d1ec into sigstore:main Aug 14, 2022
@github-actions github-actions bot added this to the v1.11.0 milestone Aug 14, 2022
cldmnky pushed a commit to cldmnky/cosign that referenced this pull request Aug 21, 2022
* Run tests using Go 1.18

Signed-off-by: Jason Hall <[email protected]>

* Suppress SHA1_RSA failures, these only occur in tests.

We should fix this with new testdata but we're blocked on an
upstream change.

Signed-off-by: Dan Lorenc <[email protected]>

Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Dan Lorenc <[email protected]>
Co-authored-by: Dan Lorenc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants