Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to go 1.18 and pin release-utils to v0.7.1 #904

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

saschagrunert
Copy link
Contributor

Summary

We should use the release versions rather than the commits on main to let dependabot update it automatically.

Release Note

NONE

Documentation

NONE

@cpanato
Copy link
Member

cpanato commented Jul 5, 2022

I think we need to have go1.18

@saschagrunert saschagrunert changed the title Pin release-utils to v0.7.1 Switch to go 1.18 and pin release-utils to v0.7.1 Jul 5, 2022
We should use the release versions rather than the commits on `main` to
let dependabot update it automatically.

Signed-off-by: Sascha Grunert <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #904 (ed4c36e) into main (79540f9) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
- Coverage   47.86%   47.83%   -0.04%     
==========================================
  Files          62       62              
  Lines        5461     5461              
==========================================
- Hits         2614     2612       -2     
- Misses       2559     2561       +2     
  Partials      288      288              
Impacted Files Coverage Δ
pkg/types/rekord/v0.0.1/entry.go 48.18% <0.00%> (-0.67%) ⬇️
pkg/types/helm/v0.0.1/entry.go 48.08% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79540f9...ed4c36e. Read the comment docs.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dlorenc dlorenc merged commit ee3f127 into sigstore:main Jul 5, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Jul 5, 2022
@saschagrunert saschagrunert deleted the release-utils branch July 5, 2022 15:23
@lukehinds
Copy link
Member

lukehinds commented Jul 6, 2022

I know this is merged now, but we need to agree on a go versioning strategy. I am of the mind that we should pin go.mod to the last supported release and then test against newer releases. When a go version deprecates, we then move up one release within go.mod. Either way, even if that is not seen as the correct approach, we right now we have some projects running go.1.17 (sigstore/sigstore) and others running go.1.18

I will put it on the community agenda for next week.

@saschagrunert
Copy link
Contributor Author

As a side note, in Kubernetes we follow the principle of always using the latest available go version, because this allows us to update critical dependencies when they require a recent go version, too.

@dlorenc
Copy link
Member

dlorenc commented Jul 6, 2022

The main driver for 1.18 has been the hashicorp dependencies that require it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants