Cherry-pick disabling of pkg.translator.prometheus.NormalizeName FG
#3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
changed the title
pkg.translator.prometheus.NormalizeName FGpkg.translator.prometheus.NormalizeName FG
jvoravong
approved these changes
Jun 12, 2023
crobert-1
approved these changes
Jun 12, 2023
rmfitzpatrick
approved these changes
Jun 12, 2023
Set `pkg.translator.prometheus.NormalizeName` feature gate back to Alpha state since it was enabled prematurely. Metrics coming from Prometheus receiver will not be normalized by default, specifically `_total` suffix will not be removed from metric names. To maintain the current behavior (drop the `_total` suffix), you can enable the feature gate using the `--feature-gates=pkg.translator.prometheus.NormalizeName` command argument. However, note that the translation in the prometheus receiver is a subject to possible future changes. See [issue #23208](open-telemetry/opentelemetry-collector-contrib#23208) for more details.
dmitryax
force-pushed
the
cherry-pick-prom-fg
branch
from
4ab24ea to
f7f6d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick open-telemetry/opentelemetry-collector-contrib#23229
Set
pkg.translator.prometheus.NormalizeNamefeature gate back to Alpha state since it was enabled prematurely. Metrics coming from Prometheus receiver will not be normalized by default, specifically_totalsuffix will not be removed from metric names. To maintain the current behavior (drop the_totalsuffix), you can enable the feature gate using the--feature-gates=pkg.translator.prometheus.NormalizeNamecommand argument. However, note that the translation in the prometheus receiver is a subject to possible future changes. See issue #23208 for more details.