Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/translator/prometheus] Switch NormalizeName FG back to alpha #23229

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jun 7, 2023

Disable pkg.translator.prometheus.NormalizeName feature gate by default

The feature gate pkg.translator.prometheus.NormalizeName was enabled prematurely while translation in the prometheus receiver was incomplete. To address this, the feature gate has been reverted back to alpha status. This will remain the case until the translation on the receiver side aligns with the translation on the exporter side or until it is replaced with a configuration option. To maintain the current behavior, you can enable the feature gate using the --feature-gates=pkg.translator.prometheus.NormalizeName command argument. However, please note that the translation in the prometheus receiver is a subject to future changes.

This is mostly a revert of #20519

Link to tracking Issue: #23208

Disable `pkg.translator.prometheus.NormalizeName` feature gate by default

The feature gate `pkg.translator.prometheus.NormalizeName` was enabled prematurely while translation on the prometheus receiver was incomplete. To address this, the feature gate has been reverted back to alpha status. This will remain the case until the translation on the receiver side aligns with the translation on the exporter side, or until it is replaced with a configuration option or completely removed. To maintain the current behavior, you can enable the feature gate using the `--feature-gates=pkg.translator.prometheus.NormalizeName` command argument. However, please note that the translation in the prometheus receiver is a subject to future changes.
@dmitryax dmitryax force-pushed the disable-prom-feature-gate branch from 56cfcc9 to 08386c2 Compare June 7, 2023 23:02
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as discussed in the SIG

@dmitryax dmitryax merged commit 47b208f into open-telemetry:main Jun 8, 2023
@github-actions github-actions bot added this to the next release milestone Jun 8, 2023
@dmitryax dmitryax deleted the disable-prom-feature-gate branch June 8, 2023 21:54
hdkshingala added a commit to fluxninja/opentelemetry-collector-contrib that referenced this pull request Jul 4, 2023
hdkshingala added a commit to fluxninja/opentelemetry-collector-contrib that referenced this pull request Jul 4, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
…pen-telemetry#23229)

Disable `pkg.translator.prometheus.NormalizeName` feature gate by default

The feature gate `pkg.translator.prometheus.NormalizeName` was enabled prematurely while translation on the prometheus receiver was incomplete. To address this, the feature gate has been reverted back to alpha status. This will remain the case until the translation on the receiver side aligns with the translation on the exporter side, or until it is replaced with a configuration option or completely removed. To maintain the current behavior, you can enable the feature gate using the `--feature-gates=pkg.translator.prometheus.NormalizeName` command argument. However, please note that the translation in the prometheus receiver is a subject to future changes.
jmichalak-fluxninja pushed a commit to fluxninja/opentelemetry-collector-contrib that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants