Skip to content

Commit

Permalink
Cherry pick disabling of pkg.translator.prometheus.NormalizeName FG (
Browse files Browse the repository at this point in the history
…#3257)

Set `pkg.translator.prometheus.NormalizeName` feature gate back to Alpha state since it was enabled prematurely. Metrics coming from Prometheus receiver will not be normalized by default, specifically `_total` suffix will not be removed from metric names. To maintain the current behavior (drop the `_total` suffix), you can enable the feature gate using the `--feature-gates=pkg.translator.prometheus.NormalizeName` command argument. However, note that the translation in the prometheus receiver is a subject to possible future changes.  See [issue #23208](open-telemetry/opentelemetry-collector-contrib#23208) for more details.
  • Loading branch information
dmitryax authored Jun 13, 2023
1 parent 32c02f1 commit cbe3d9b
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@

## Unreleased

### 🛑 Breaking changes 🛑

- (Contrib) Set `pkg.translator.prometheus.NormalizeName` feature gate back to Alpha state since it was enabled
prematurely. Metrics coming from Prometheus receiver will not be normalized by default, specifically `_total` suffix
will not be removed from metric names. To maintain the current behavior (drop the `_total` suffix), you can enable
the feature gate using the `--feature-gates=pkg.translator.prometheus.NormalizeName` command argument. However, note
that the translation in the prometheus receiver is a subject to possible future changes.
([#23229](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/23229))

## v0.78.1

### 🧰 Bug fixes 🧰
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/oracledbreceiver v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusexecreceiver v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.1-0.20230612155822-9d5526cf2998
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/receivercreator v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redisreceiver v0.79.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sapmreceiver v0.79.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1260,8 +1260,8 @@ github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlrec
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver v0.79.0/go.mod h1:DBMFnjkKSXJmqA6w2RomPDKlW5XHAHJM6xtDqLLTCGs=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusexecreceiver v0.79.0 h1:K871tj1LnnJ2qu1AHlxx94gi8X1t7BCJ9BbFf9rGOOU=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusexecreceiver v0.79.0/go.mod h1:xAXBpCVNAU8Y9AlFiQzU3JvJnDxM4otcW14FZnksa6I=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.0 h1:+mJSVctdGemxKt2O6ZaccrNEiWQ7OCRuGfD+9nUEZRg=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.0/go.mod h1:+0BrsZx0PGVAnAdHS5F1du1AbUqsEwBrg1UrQfKPdd8=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.1-0.20230612155822-9d5526cf2998 h1:soVXfvycoHWwXYCXbA/4+S9ktbEzohCshtBlagmDKPg=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.79.1-0.20230612155822-9d5526cf2998/go.mod h1:M4t+1NhOsJKd25EeosRjdBpy/5Qnb0RVCMoOHNrzs80=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/receivercreator v0.79.0 h1:PIOFy5/GivJuDhy97R4KnRic2BB777Vf45b3WAP+GYE=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/receivercreator v0.79.0/go.mod h1:jKSUs5RXRuYMb66RshAJXADv35+4+PMSb+/y6UVGI9U=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redisreceiver v0.79.0 h1:CuZbOGP8y0FHgNHZTefTQNXIvnLwy7xGYF4a+GjQFn8=
Expand Down

0 comments on commit cbe3d9b

Please sign in to comment.