Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Render actions fail when non Helm values yamls are present in the examples directory #686

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

jvoravong
Copy link
Contributor

Description:

  • I would like to create examples in this project that contain yaml files that are not Helm values files.
  • The "make render" command reads all yaml files in our examples and will throw an error if it can't render the yaml file. In this PR I make it so only yaml files ending in "values.yaml" are rendered.
  • Some of our example Helm values yaml files needed to be renamed to accommodate this change.

@jvoravong jvoravong requested review from a team as code owners March 3, 2023 22:56
@jvoravong jvoravong changed the title Bug fix: Render actions fails when non Helm values yamls are present in the examples directory Bug fix: Render actions fail when non Helm values yamls are present in the examples directory Mar 3, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@jvoravong jvoravong merged commit d1d49e6 into signalfx:main Mar 6, 2023
@jvoravong jvoravong deleted the bug-fix-render branch March 6, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants