Bug fix: Render actions fail when non Helm values yamls are present i…

…n the examples directory (#686) * Bug Fix: Make the render-examples.sh script only renders values.yaml files * Rename example helm values files to end in "values.yaml"
signalfx · Mar 6, 2023 · d1d49e6 · d1d49e6
1 parent e604320
commit d1d49e6
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 2 deletions.
diff --git a/examples/README.md b/examples/README.md
@@ -4,7 +4,7 @@
 
 Each example has a directory where each of the following is included.
 - README.md: A short description about the example.
-- A Helm values configuration file to demonstrate the example.
+- A Helm values configuration file to demonstrate the example, the file name always ends in values.yaml.
 - A rendered_manifests directory that contains the rendered Kubernetes manifests for the example.
   - Search for "CHANGEME" to find the values that must be changed in order to use the rendered manifests directly.
 

diff --git a/...nced/collector-gateway-only-advanced.yaml → ...llector-gateway-only-advanced-values.yaml b/...nced/collector-gateway-only-advanced.yaml → ...llector-gateway-only-advanced-values.yaml
diff --git a/...rk-explorer/enable-network-expolorer.yaml → ...orer/enable-network-expolorer-values.yaml b/...rk-explorer/enable-network-expolorer.yaml → ...orer/enable-network-expolorer-values.yaml
diff --git a/.../only-logs-fluentd/only-logs-fluentd.yaml → ...ogs-fluentd/only-logs-fluentd-values.yaml b/.../only-logs-fluentd/only-logs-fluentd.yaml → ...ogs-fluentd/only-logs-fluentd-values.yaml
diff --git a/examples/only-logs-otel/only-logs-otel.yaml → ...only-logs-otel/only-logs-otel-values.yaml b/examples/only-logs-otel/only-logs-otel.yaml → ...only-logs-otel/only-logs-otel-values.yaml
diff --git a/examples/only-metrics/only-metrics.yaml → ...les/only-metrics/only-metrics-values.yaml b/examples/only-metrics/only-metrics.yaml → ...les/only-metrics/only-metrics-values.yaml
diff --git a/examples/only-traces/only-traces.yaml → examples/only-traces/only-traces-values.yaml b/examples/only-traces/only-traces.yaml → examples/only-traces/only-traces-values.yaml
diff --git a/examples/render-examples.sh b/examples/render-examples.sh
@@ -6,7 +6,7 @@ SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 render_task(){
   example_dir=$1
   rendered_manifests_dir=$example_dir"rendered_manifests"
-	values_yaml=$example_dir`ls $example_dir | grep yaml`
+	values_yaml=$example_dir`ls $example_dir | grep values.yaml`
 
   # Clear out all rendered manifests
   rm -rf $rendered_manifests_dir