Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Render actions fail when non Helm values yamls are present in the examples directory #686

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Bug fix: Render actions fail when non Helm values yamls are present in the examples directory #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e097787
Bug Fix: Make the render-examples.sh script only renders values.yaml …
jvoravong Mar 3, 2023
4536dcf
Rename example helm values files to end in "values.yaml"
jvoravong Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Each example has a directory where each of the following is included.
- README.md: A short description about the example.
- A Helm values configuration file to demonstrate the example.
- A Helm values configuration file to demonstrate the example, the file name always ends in values.yaml.
- A rendered_manifests directory that contains the rendered Kubernetes manifests for the example.
- Search for "CHANGEME" to find the values that must be changed in order to use the rendered manifests directly.

Expand Down
0 ...nced/collector-gateway-only-advanced.yaml → ...llector-gateway-only-advanced-values.yaml
View file
Open in desktop
File renamed without changes.
0 ...rk-explorer/enable-network-expolorer.yaml → ...orer/enable-network-expolorer-values.yaml
View file
Open in desktop
File renamed without changes.
0 .../only-logs-fluentd/only-logs-fluentd.yaml → ...ogs-fluentd/only-logs-fluentd-values.yaml
View file
Open in desktop
File renamed without changes.
0 examples/only-logs-otel/only-logs-otel.yaml → ...only-logs-otel/only-logs-otel-values.yaml
View file
Open in desktop
File renamed without changes.
0 examples/only-metrics/only-metrics.yaml → ...les/only-metrics/only-metrics-values.yaml
View file
Open in desktop
File renamed without changes.
0 examples/only-traces/only-traces.yaml → examples/only-traces/only-traces-values.yaml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/render-examples.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
render_task(){
example_dir=$1
rendered_manifests_dir=$example_dir"rendered_manifests"
values_yaml=$example_dir`ls $example_dir | grep yaml`
values_yaml=$example_dir`ls $example_dir | grep values.yaml`

# Clear out all rendered manifests
rm -rf $rendered_manifests_dir
Expand Down