-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust network provider #713
Merged
breedx-splk
merged 17 commits into
signalfx:main
from
breedx-splk:adjust_network_provider
Dec 13, 2023
Merged
Adjust network provider #713
breedx-splk
merged 17 commits into
signalfx:main
from
breedx-splk:adjust_network_provider
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
force-pushed
the
adjust_network_provider
branch
from
December 12, 2023 19:08
eafce33
to
7e624b5
Compare
laurit
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to:
Moves the creation of the network provider closer to its usage and then calls the setter to allow sharing of the instance with the underlying implementation. It then removes the explicit setup/installation of the network component.
Note that the network provider is still used by the bespoke disk buffering exporter to ensure that the network is available for sending.