Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust network provider #713

Merged
merged 17 commits into from
Dec 13, 2023
Merged

Conversation

breedx-splk
Copy link
Contributor

This needs to:

  1. Rebase after Leverage upstream improvements #710 is merged (this builds on that)
  2. Wait until Add network change monitoring open-telemetry/opentelemetry-android#176 in upstream is merged.

Moves the creation of the network provider closer to its usage and then calls the setter to allow sharing of the instance with the underlying implementation. It then removes the explicit setup/installation of the network component.

Note that the network provider is still used by the bespoke disk buffering exporter to ensure that the network is available for sending.

@breedx-splk breedx-splk force-pushed the adjust_network_provider branch from eafce33 to 7e624b5 Compare December 12, 2023 19:08
@breedx-splk breedx-splk marked this pull request as ready for review December 12, 2023 19:09
@breedx-splk breedx-splk requested review from a team as code owners December 12, 2023 19:09
@breedx-splk breedx-splk merged commit 768610c into signalfx:main Dec 13, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants