Leverage upstream improvements #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
force-pushed
the
leverage_upstream_improvements
branch
from
d43aa1a to
598efc9
Compare
Merged
laurit
reviewed
Dec 8, 2023
| @@ -104,14 +111,6 @@ SplunkRum initialize( | |||
| // TODO: How truly important is the order of these span processors? The location of event | |||
There was a problem hiding this comment.
is this comment still relevant?
There was a problem hiding this comment.
Not really, I'll remove it in #713. 👍🏻
laurit
approved these changes
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to migrate functionality to upstream. This one removes distro implementation for: