Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instrumentation that reports network changes has not yet been wired up. This adds it to the configuration and enables the instrumentation in the builder's
build()
.One additional aspect is that the
CurrentNetworkProvider
now has a setter on theOpenTelemetryRumBuilder
. This allows existing components that may rely on this functionality to share the instance. The creation is lazy, so that if the builder user didn't create one, it is created at build time on demand.I expect this
CurrentNetworkProvider
sharing to hopefully not be necessary in the long term, but right now there are existing disk buffering implementations (eg. Splunk's distro) that also need to determine information about the current network availability before attempting export.