2.0 #517
Merged
2.0 #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyphens are checked by default.
url crate: remove rustc-serialize optional dependency Part of #506 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/507) <!-- Reviewable:end -->
It is deprecated since 1.26.0 if the inherent methods, that are stable since 1.23.0, want to be relied on.
This requires at least rustc 1.24.0 as only then the function became stably const-fn.
The 1.24.0 release has been over a year ago and is needed by the prior commits.
Update to serde 1.0 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/512) <!-- Reviewable:end -->
Make the tests use serde_json instead of rustc_serialize Part of #506 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/514) <!-- Reviewable:end -->
|
r+ your commits, let's merge it on 2.0 so we can continue making changes there. |
|
This is the |
|
Yeah I know, I meant we should merge it so we can make other PRs against 2.0, sorry that wasn't clear. |
|
Per IRC discussion: @bors-servo r=nox |
|
📌 Commit 50c3efe has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 17, 2019
2.0 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/517) <!-- Reviewable:end -->
|
☀️ Test successful - checks-travis |
This was referenced Jul 17, 2019
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is