Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::net::ToSocketAddrs dropped from 2.0.0 #530

Closed
saschagrunert opened this issue Jul 25, 2019 · 2 comments
Closed

std::net::ToSocketAddrs dropped from 2.0.0 #530

saschagrunert opened this issue Jul 25, 2019 · 2 comments

Comments

@saschagrunert
Copy link

saschagrunert commented Jul 25, 2019 •
edited
Loading

Was it intended to remove the trait std::net::ToSocketAddrs from 2.0.0 via #517 (6e08201)? I mean these implementation was pretty handy when it comes to create web servers via the Url type.
@SimonSapin
Copy link
Member

Yes it was intended. DNS resolution required a disproportionate amount of API surface, for functionality which is not really what this crate is about.

The replacement looks like this: https://github.com/snapview/tungstenite-rs/pull/63/files#diff-31bbf71c54bca98a0ae3d40a327af940R90

@saschagrunert
Copy link
Author

I see, thanks for the help 🙏

@LPardue LPardue mentioned this issue Jul 29, 2019
Closed
@benesch benesch mentioned this issue Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonSapin @saschagrunert