Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tests use serde_json instead of rustc_serialize #514

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

est31
Copy link
Contributor

@est31 est31 commented Jul 14, 2019

Part of #506


This change is Reviewable

@est31 est31 mentioned this pull request Jul 14, 2019
3 tasks
@est31 est31 force-pushed the no_rustc_serialize branch 2 times, most recently from 66e3659 to 422dec6 Compare July 14, 2019 23:40
@est31 est31 changed the title Make the tests serde_json instead of rustc_serialize Make the tests use serde_json instead of rustc_serialize Jul 14, 2019
@est31 est31 force-pushed the no_rustc_serialize branch from 422dec6 to b97ef45 Compare July 15, 2019 06:44
@est31 est31 force-pushed the no_rustc_serialize branch from b97ef45 to a1ed777 Compare July 15, 2019 06:45
@SimonSapin
Copy link
Member

Looks good, thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a1ed777 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit a1ed777 with merge f75aef7...

bors-servo pushed a commit that referenced this pull request Jul 15, 2019
Make the tests use serde_json instead of rustc_serialize

Part of #506

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/514)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: SimonSapin
Pushing f75aef7 to 2.0...

@bors-servo bors-servo merged commit a1ed777 into servo:2.0 Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants