Upgrade to url v2.0 #583
Merged
Upgrade to url v2.0 #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2019
Closed
benesch
force-pushed
the
url-20
branch
3 times, most recently
from
8c8ed47 to
0990b79
Compare
benesch
force-pushed
the
url-20
branch
2 times, most recently
from
f6b20a8 to
6887f06
Compare
|
Ok, this is finally ready to go! @seanmonstar, mind taking a look? cookie-rs only has an internal dependency on url, so as it turns out it doesn't matter that it hasn't released a version that depends on url 2.0. |
seanmonstar
reviewed
Sep 4, 2019
src/async_impl/multipart.rs
Outdated
| @@ -16,7 +16,7 @@ pub struct Form { | |||
| inner: FormParts<Part>, | |||
| } | |||
|
|
|||
| /// A field in a multipart form. | |||
| /// A field in a multipart form.©398 | |||
There was a problem hiding this comment.
D'oh! I guess I can blame that on my cat. Thanks for catching it.
benesch
commented
Sep 5, 2019
src/async_impl/multipart.rs
Outdated
| @@ -16,7 +16,7 @@ pub struct Form { | |||
| inner: FormParts<Part>, | |||
| } | |||
|
|
|||
| /// A field in a multipart form. | |||
| /// A field in a multipart form.©398 | |||
There was a problem hiding this comment.
D'oh! I guess I can blame that on my cat. Thanks for catching it.
|
Looks like the rustfmt check is grumpy now :( |
|
Looks like today is not my day. Thanks for bearing with me! Should be fixed now! (I waited for a green CI build this time.) |
|
Great, thanks for sticking with it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on upgrading quite a few other crates in the ecosystem:
rwf2/cookie-rs#122✓For the moment I've used a Cargo.toml patch block to point at those PRs. We'll need to get actual releases of those dependencies before we can merge this, but wanted to open the PR in the meantime.
Fix #582.