Upgrade to url v2.0 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benesch I don't have an issue taking this PR once upstream has done so, but for my understanding on motivation: does I will keep my eye on notifications and merge once the '[patch.crates-io]' entries are no longer necessary. |
|
Just a keeping up with the ecosystem change! Any crate that depends on reqwest is stuck with url 1.0 (since url is a fundamental part of the reqwest API) until reqwest upgrades to url 2.0. |
benesch
force-pushed
the
url-20
branch
2 times, most recently
from
62be400 to
d6cc263
Compare
|
Ok, @pfernie, this is ready to go! |
|
@benesch This is merged, thx! |
|
Thank you, @pfernie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to upgrade reqwest to url 2.0, and it's proving to be quite the challenge. Upgrading cookie_store's version of url is one piece of the puzzle.
This PR is blocked on two upstream dependencies updating first:
For now, I've used a
[patch.crates-io]block here in order to verify the change, but I'll remove that block as soon as the upstream PRs make it into their respective releases.