Expose lifetimes in UrlEncodedSerializer #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcing UrlEncodedSerializer to have a 'static lifetime is unnecessarily restrictive and breaks a downstream dependency, reqwest. Thread a new lifetime through to fix the problem.
|
/cc @SimonSapin |
|
Sounds reasonable. I took a shortcut with |
|
No worries! I suppose this is the kind of thing that would, in principle, be caught if url had shipped a v2.0 prerelease version, but a) I guess Cargo doesn't handle prereleases (?!) (rust-lang/cargo#2222), and b) it's unlikely that the prerelease chain would have continued far enough to have actually caught this. |
|
bors r+ Thanks for the quick reaction @benesch, I'll release |
bors bot
added a commit
that referenced
this pull request
Jul 31, 2019
59: Expose lifetimes in UrlEncodedSerializer r=nox a=benesch Forcing UrlEncodedSerializer to have a 'static lifetime is unnecessarily restrictive and breaks a downstream dependency, reqwest. Thread a new lifetime through to fix the problem. Co-authored-by: Nikhil Benesch <[email protected]>
Build succeeded |
|
Fantastic! Thanks for the quick merge and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing UrlEncodedSerializer to have a 'static lifetime is unnecessarily
restrictive and breaks a downstream dependency, reqwest. Thread a new
lifetime through to fix the problem.