vm_arm: add pcpu list for core pinning #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apave24
force-pushed
the
core-pinning
branch
from
175709b
to
eadf2e8
Compare
yyshen
approved these changes
Nov 22, 2022
|
Please add the DCO. |
|
Please rebase this, and add the signed-off-by: line in your commit message. |
Apave24
force-pushed
the
core-pinning
branch
from
20e04e9
to
b2284ea
Compare
|
Bumping this PR. I believe everything has been addressed. |
|
The CI build is failing with include errors, but I wonder if this is related the the change here or a general probelm? |
It's at least not a CI glitch, one of the recently merged PRs must have introduced this problem (or it is introduced here). |
|
The current status of camkes-vm-examples is green, with the most recent tested manifest being this one: |
|
@Apave24 could you do a rebase, so we get another CI run here? |
axel-h
reviewed
Apr 19, 2023
chrisguikema
force-pushed
the
core-pinning
branch
2 times, most recently
from
5d4a348
to
727df13
Compare
axel-h
reviewed
Feb 1, 2024
Adds a pcpu list to the VM_Arm component to allow pinning of vcpus to specific physical cpus within a CAmkES configuration. Signed-off-by: Alex Pavey <[email protected]>
chrisguikema
force-pushed
the
core-pinning
branch
from
727df13
to
aff0b99
Compare
Signed-off-by: Alex Pavey <[email protected]>
chrisguikema
force-pushed
the
core-pinning
branch
from
aff0b99
to
f060b5c
Compare
axel-h
reviewed
Feb 1, 2024
| /*- endfor -*/ | ||
| /*- endif -*/ | ||
|
|
||
| int get_instance_size_pcpus_list(void) { |
There was a problem hiding this comment.
Suggested change
| int get_instance_size_pcpus_list(void) { | |
| unsigned int get_instance_size_pcpus_list(void) { |
axel-h
reviewed
Feb 1, 2024
| @@ -1270,8 +1271,26 @@ static int main_continued(void) | |||
| } | |||
| } | |||
|
|
|||
| int pcpu_assignments = 0; | |||
There was a problem hiding this comment.
Let's avoid assigning 0 and then overwriting this, it gives compiler warnings at the picky level.
unsigned int pcpu_assignments = get_instance_size_pcpus_list();
if (pcpu_assignments > NUM_VCPUS) {
pcpu_assignments = NUM_VCPUS;
}
There was a problem hiding this comment.
Or well, we could even merge this nicely into the CPU node creation at line 1260:
/* Create CPUs and DTB node */
unsigned int pcpu_list_size = get_instance_size_pcpus_list();
for (int i = 0; i < NUM_VCPUS; i++) {
vm_vcpu_t *new_vcpu = create_vmm_plat_vcpu(&vm, VM_PRIO - 1);
assert(new_vcpu);
if (i < pcpu_list_size) {
/* Assign VCPU to explicit physical CPU */
new_vcpu->target_cpu = pcpus[i];
}
}
// ... and now generate the device tree VCPU nodes
axel-h
reviewed
Feb 1, 2024
| @@ -42,3 +42,5 @@ typedef struct { | |||
| } vm_config_t; | |||
|
|
|||
| extern const vm_config_t vm_config; | |||
|
|
|||
| int get_instance_size_pcpus_list(void); | |||
There was a problem hiding this comment.
Suggested change
| int get_instance_size_pcpus_list(void); | |
| unsigned int get_instance_size_pcpus_list(void); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pcpu list to the VM_Arm component to allow pinning of vcpus to specific physical cpus within a CAmkES configuration.
Test with: seL4/seL4_projects_libs#84