Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Multicore Improvements #121

Merged
merged 3 commits into from
May 25, 2023
Merged

General Multicore Improvements #121

merged 3 commits into from
May 25, 2023

Conversation

Apave24
Copy link

@Apave24 Apave24 commented Nov 11, 2022

These commits make the following general improvements:

  • add a camkes function to allow a component to get the affinity that was set for it in the camkes config
  • add a build time error checking for the affinity and num_vcpus attributes to avoid needing to wait for runtime errors to occur
  • allow a components fault handler thread to always be on the same core as it's control thread when the affinity attribute is set

@Apave24 Apave24 mentioned this pull request Nov 11, 2022
Open
axel-h
axel-h approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@axel-h axel-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me.

@Apave24
Copy link
Author

Apave24 commented Mar 8, 2023

Bumping this PR. I believe everything has been addressed.

@axel-h
Copy link
Member

axel-h commented Mar 10, 2023

@Apave24 could you rebase this, then we also get another CI run there to see if this passes.

chrisguikema and others added 3 commits March 10, 2023 06:44
@chrisguikema
Allow camkes components to know affinity
3aa63f4 
Signed-off-by: Alex Pavey <[email protected]>
Add build time error check for affinity
5e950da 
Signed-off-by: Alex Pavey <[email protected]>
Put fault handler and control on the same core
5cee643 
The fault handler thread currently is set to the default core which can
cause a component's fault handler threads and control threads to be on
separate cores if the affinity attribute is set. This change sets the
fault handler thread and control thread to run on the same core.

Signed-off-by: Alex Pavey <[email protected]>
@axel-h
Copy link
Member

axel-h commented Mar 10, 2023 •
edited
Loading

Seems this is breaking the build on optiplex9020

  vm1/camkes.c:43:2: error: #error "Invalid Affinity Value of 1"
     43 | #error "Invalid Affinity Value of 1"
        |  ^~~~~

@axel-h axel-h mentioned this pull request Mar 13, 2023
Closed
@kent-mcleod
Copy link
Member

Seems this is breaking the build on optiplex9020

That example appears to have a broken configuration that the new change is catching.

@kent-mcleod kent-mcleod merged commit 73c90a4 into seL4:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axel-h axel-h axel-h approved these changes

@kent-mcleod kent-mcleod kent-mcleod approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Apave24 @axel-h @kent-mcleod @chrisguikema