-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting Function for Arm VM core pinning #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. we could do more sanity checks (duplicates...), but that can also be a follow-up.
899f1dd
to
716a888
Compare
CAmkES has a mechanism for adding templates to a component (https://github.com/seL4/camkes-tool/blob/master/camkes.cmake#L606-L607). VM specific configuration to be passed into the VM_Arm component should be implemented using a VM_Arm specific template instead of the base component templates. For an example, the recent additions of the seL4AllocatorMempool configuration (https://github.com/seL4/camkes-vm/blob/master/arm_vm_helpers.cmake#L134-L137) use the same approach. |
Moved commit to camkes-vm#54 |
@Apave24 could you rebase this, then we also get another CI run there to see if this passes. |
Signed-off-by: Alex Pavey <[email protected]>
The build fails, because seL4/camkes-vm#54 depends on #121. |
Since we have a component specific template in seL4/camkes-vm#54, it seem this is obsolete now and can be closed? |
Closing due to ^ |
This commit adds supporting functionality for adding a pcpu list attribute to the VM_Arm component for specially defining what physical cpus a VM's vcpus should be pinned to.
Test with: seL4/camkes-vm#54