build: Clean up compile_option after FindSanitizers module
#2548
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unset the `compile_option` variable after it's used in the FindSanitizers module to prevent potential conflicts with other CMake build configurations. Previously, this variable persisted after `find_package(Sanitizers)`, which could lead to unexpected build behavior if the same variable name was used elsewhere. This change follows CMake best practices where Find modules clean up temporary variables after use. Signed-off-by: Kefu Chai <[email protected]>
|
Not part of the team, but LGTM. |
All reviews are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unset the
compile_optionvariable after it's used in the FindSanitizers module to prevent potential conflicts with other CMake build configurations. Previously, this variable persisted afterfind_package(Sanitizers), which could lead to unexpected build behavior if the same variable name was used elsewhere.This change follows CMake best practices where Find modules clean up temporary variables after use.