Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Clean up compile_option after FindSanitizers module #2548

Merged
merged 1 commit into from
Nov 25, 2024

Commits on Nov 25, 2024

  1. build: Clean up compile_option after FindSanitizers module

    Unset the `compile_option` variable after it's used in the FindSanitizers
    module to prevent potential conflicts with other CMake build configurations.
    Previously, this variable persisted after `find_package(Sanitizers)`,
    which could lead to unexpected build behavior if the same variable name
    was used elsewhere.
    
    This change follows CMake best practices where Find modules clean up
    temporary variables after use.
    
    Signed-off-by: Kefu Chai <[email protected]>
    tchaikov committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    491bd69 View commit details
    Browse the repository at this point in the history