build: Clean up compile_option after FindSanitizers module

Unset the `compile_option` variable after it's used in the FindSanitizers module to prevent potential conflicts with other CMake build configurations. Previously, this variable persisted after `find_package(Sanitizers)`, which could lead to unexpected build behavior if the same variable name was used elsewhere. This change follows CMake best practices where Find modules clean up temporary variables after use. Signed-off-by: Kefu Chai <[email protected]>
scylladb · Nov 25, 2024 · 7dbd974 · 7dbd974
1 parent 0d1781c
commit 7dbd974
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/cmake/FindSanitizers.cmake b/cmake/FindSanitizers.cmake
@@ -40,6 +40,7 @@ foreach (component ${Sanitizers_FIND_COMPONENTS})
     message (FATAL_ERROR "Unsupported sanitizer: ${component}")
   endif ()
   list(APPEND Sanitizers_COMPILE_OPTIONS "${${compile_options}}")
+  unset (compile_options)
 endforeach ()
 
 include(CheckCXXSourceCompiles)